Skip to content

861: Swap toggle button and text - #866

Merged
naanci merged 1 commit into
mainfrom
861
Mar 22, 2026
Merged

861: Swap toggle button and text#866
naanci merged 1 commit into
mainfrom
861

Conversation

@naanci

@naanci naanci commented Mar 18, 2026

Copy link
Copy Markdown
Member

861

Description of changes

swagged toggle button and text

Checklist before review

  • I have done a thorough self-review of the PR
  • Copilot has reviewed my latest changes, and all comments have been fixed and/or closed.
  • If I have made database changes, I have made sure I followed all the db repo rules listed in the wiki here. (check if no db changes)
  • All tests have passed
  • I have successfully deployed this PR to staging
  • I have done manual QA in both dev (and staging if possible) and attached screenshots below.

Screenshots

Dev

Screenshot 2026-03-17 at 9 31 29 PM Screenshot 2026-03-17 at 9 31 38 PM

Staging

Screenshot 2026-03-17 at 9 55 13 PM Screenshot 2026-03-17 at 9 55 27 PM

@github-actions

Copy link
Copy Markdown
Contributor

Available PR Commands

  • /ai - Triggers all AI review commands at once
  • /review - AI review of the PR changes
  • /describe - AI-powered description of the PR
  • /improve - AI-powered suggestions
  • /deploy - Deploy to staging

See: https://github.com/tahminator/codebloom/wiki/CI-Commands

@naanci

naanci commented Mar 18, 2026

Copy link
Copy Markdown
Member Author

/deploy

@github-actions

Copy link
Copy Markdown
Contributor

Title

861: Swap toggle button and text


PR Type

Enhancement


Description

  • Reorder filter dropdown elements.

  • Move Switch component to rightSection.

  • Place Checkbox component in leftSection.

  • Apply conditional rendering based on switchMode.


Diagram Walkthrough

flowchart LR
  FilterDropdownItem -- "if switchMode is true" --> SwitchInRightSection[Switch in rightSection]
  FilterDropdownItem -- "if switchMode is false" --> CheckboxInLeftSection[Checkbox in leftSection]
Loading

File Walkthrough

Relevant files
Enhancement
FilterDropdownItem.tsx
Reorder Switch and Checkbox in FilterDropdownItem               

js/src/components/ui/dropdown/FilterDropdownItem.tsx

  • Moved the Switch component to the rightSection of the Menu.Item when
    switchMode is active.
  • Placed the Checkbox component in the leftSection of the Menu.Item when
    switchMode is inactive.
  • Ensured the onClick handler is correctly passed to the Switch
    component.
  • Updated conditional rendering logic for component placement within the
    dropdown item.
+5/-2     

@github-actions

Copy link
Copy Markdown
Contributor

PR Reviewer Guide 🔍

Here are some key observations to aid the review process:

**🎫 Ticket compliance analysis **

⏱️ Estimated effort to review: 1 🔵⚪⚪⚪⚪
🧪 No relevant tests
🔒 No security concerns identified
⚡ No major issues detected

Comment thread js/src/components/ui/dropdown/FilterDropdownItem.tsx
@angelayu0530
angelayu0530 self-requested a review March 18, 2026 14:40
@naanci

naanci commented Mar 19, 2026

Copy link
Copy Markdown
Member Author

/deploy

@naanci
naanci enabled auto-merge (rebase) March 19, 2026 01:33
@github-actions

Copy link
Copy Markdown
Contributor

Title

861: Swap toggle button and text


PR Type

Enhancement


Description

  • Reordered interactive elements in filter dropdown.

  • Moved Switch component to rightSection.

  • Ensured Checkbox remains in leftSection.


File Walkthrough

Relevant files
Ui changes
FilterDropdownItem.tsx
Reordered toggle and checkbox within filter dropdown item

js/src/components/ui/dropdown/FilterDropdownItem.tsx

  • Moved the Switch component from the leftSection to the rightSection of
    the Menu.Item.
  • Updated conditional rendering to display Switch in rightSection when
    switchMode is true.
  • Ensured Checkbox component remains in the leftSection when switchMode
    is false.
+5/-2     

@github-actions

Copy link
Copy Markdown
Contributor

PR Reviewer Guide 🔍

Here are some key observations to aid the review process:

**🎫 Ticket compliance analysis **

⏱️ Estimated effort to review: 1 🔵⚪⚪⚪⚪
🧪 No relevant tests
🔒 No security concerns identified
⚡ No major issues detected

Comment thread js/src/components/ui/dropdown/FilterDropdownItem.tsx
@naanci

naanci commented Mar 22, 2026

Copy link
Copy Markdown
Member Author

/deploy

@github-actions

Copy link
Copy Markdown
Contributor

PR Description Required

Please fill out the Description of changes section of the PR.

@github-actions

Copy link
Copy Markdown
Contributor

Title

861: Swap toggle button and text


PR Type

Enhancement


Description

  • Relocated Switch component to rightSection.

  • Checkbox remains in leftSection when switchMode is false.

  • Aligns interactive elements with text in FilterDropdownItem.


Diagram Walkthrough

flowchart LR
  A["FilterDropdownItem"] --> B{"switchMode active?"}
  B -- "Yes" --> C["Switch (rightSection)"]
  B -- "No" --> D["Checkbox (leftSection)"]
Loading

File Walkthrough

Relevant files
Enhancement
FilterDropdownItem.tsx
Relocate `Switch` to `rightSection` in `FilterDropdownItem`

js/src/components/ui/dropdown/FilterDropdownItem.tsx

  • Modified the leftSection of Menu.Item to conditionally render a
    Checkbox only when switchMode is false.
  • Introduced a rightSection to Menu.Item to conditionally render a
    Switch component when switchMode is true.
  • This change effectively moves the Switch component from the
    leftSection to the rightSection when switchMode is active, while
    keeping the Checkbox in the leftSection when switchMode is inactive.
+5/-2     

@github-actions

Copy link
Copy Markdown
Contributor

PR Reviewer Guide 🔍

Here are some key observations to aid the review process:

**🎫 Ticket compliance analysis **

⏱️ Estimated effort to review: 1 🔵⚪⚪⚪⚪
🧪 No relevant tests
🔒 No security concerns identified
⚡ No major issues detected

@github-actions

Copy link
Copy Markdown
Contributor

PR Code Suggestions ✨

No code suggestions found for the PR.

@github-actions

Copy link
Copy Markdown
Contributor

PR Description Required

Please fill out the Description of changes section of the PR.

@naanci
naanci merged commit d8f8fd5 into main Mar 22, 2026
45 of 48 checks passed
@naanci
naanci deleted the 861 branch March 22, 2026 01:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants